From b2a41afc440c86ad9e20b31ab838da03a2dc04b3 Mon Sep 17 00:00:00 2001 From: paddy Date: Wed, 16 Sep 2026 20:46:26 +0200 Subject: [PATCH] replace out of range rounding with transposing --- .../meteorclient/systems/modules/misc/Notebot.java | 6 +++--- .../utils/notebot/decoder/SongDecoders.java | 10 ++++++++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/main/java/meteordevelopment/meteorclient/systems/modules/misc/Notebot.java b/src/main/java/meteordevelopment/meteorclient/systems/modules/misc/Notebot.java index d26a52c0d4a..e81bf20d437 100644 --- a/src/main/java/meteordevelopment/meteorclient/systems/modules/misc/Notebot.java +++ b/src/main/java/meteordevelopment/meteorclient/systems/modules/misc/Notebot.java @@ -117,9 +117,9 @@ public class Notebot extends Module { .build() ); - public final Setting roundOutOfRange = sgGeneral.add(new BoolSetting.Builder() - .name("round-out-of-range") - .description("Rounds out of range notes") + public final Setting transposeOutOfRange = sgGeneral.add(new BoolSetting.Builder() + .name("transpose-out-of-range") + .description("Transposes out of range notes") .defaultValue(false) .build() ); diff --git a/src/main/java/meteordevelopment/meteorclient/utils/notebot/decoder/SongDecoders.java b/src/main/java/meteordevelopment/meteorclient/utils/notebot/decoder/SongDecoders.java index c3565a598ee..771deb1f39e 100644 --- a/src/main/java/meteordevelopment/meteorclient/utils/notebot/decoder/SongDecoders.java +++ b/src/main/java/meteordevelopment/meteorclient/utils/notebot/decoder/SongDecoders.java @@ -79,8 +79,14 @@ private static void fixSong(Song song) { int n = note.getNoteLevel(); if (n < 0 || n > 24) { - if (notebot.roundOutOfRange.get()) { - note.setNoteLevel(n < 0 ? 0 : 24); + if (notebot.transposeOutOfRange.get()) { + while (n < 0) { + n += 12; + } + while (n > 24) { + n -= 12; + } + note.setNoteLevel(n); } else { notebot.warning("Note at tick %d out of range.", tick); iterator.remove();