refactor: simplify multimodal preprocessing expansion#4663
Open
CUHKSZzxy wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors get_expanded_mm_items multimodal preprocessing to split bundled HF-processor outputs into dedicated image/video/audio expansion helpers, and clarifies the intended offset layouts for whole-video vs per-frame video items to keep MultiModalData’s one-span-per-item contract.
Changes:
- Added
_expand_bundled_image_items,_expand_bundled_video_items, and_expand_bundled_audio_itemshelpers and delegated bundled expansion to them. - Made video expansion distinguish “one offset per video” vs “one offset per frame” paths more explicitly.
- Simplified non-bundled
video_second_per_gridscalar extraction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Assistance
Assisted with Codex + GPT-5.5 xHigh Fast