Skip to content

refactor: unify interleaved MRoPE rotary embedding#4644

Draft
CUHKSZzxy wants to merge 5 commits into
InternLM:mainfrom
CUHKSZzxy:refactor/unify-interleaved-mrope
Draft

refactor: unify interleaved MRoPE rotary embedding#4644
CUHKSZzxy wants to merge 5 commits into
InternLM:mainfrom
CUHKSZzxy:refactor/unify-interleaved-mrope

Conversation

@CUHKSZzxy

@CUHKSZzxy CUHKSZzxy commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • unify MRoPE rotary table generation so Qwen3-VL interleaved MRoPE and Qwen2-style chunked MRoPE share the backend rotary embedding path
  • keep text-only position ids on the regular RoPE path
  • add focused coverage for chunked MRoPE, interleaved MRoPE, YaRN MRoPE overrides, and text-position fallback
  • remove the MRoPE position-id padding helper and its dedicated test case

Validation

  • focused rotary embedding unit tests passed

Assistance

Assisted with Codex + GPT-5.5 xHigh Fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant