diff --git a/buildSrc/src/main/kotlin/dd-trace-java.conventions.java.gradle.kts b/buildSrc/src/main/kotlin/dd-trace-java.conventions.java.gradle.kts index 171115e3d0b..0c55ab62967 100644 --- a/buildSrc/src/main/kotlin/dd-trace-java.conventions.java.gradle.kts +++ b/buildSrc/src/main/kotlin/dd-trace-java.conventions.java.gradle.kts @@ -1,2 +1,6 @@ -// Keep gradle/java.gradle as the source of truth while consumers move to plugins {}. -apply(from = rootDir.resolve("gradle/java.gradle")) +plugins { + id("dd-trace-java.dependency-locking") +} + +apply(from = rootDir.resolve("gradle/java_deps.gradle")) +apply(from = rootDir.resolve("gradle/java_no_deps.gradle")) diff --git a/gradle/java.gradle b/gradle/java.gradle deleted file mode 100644 index 86f2dac02f8..00000000000 --- a/gradle/java.gradle +++ /dev/null @@ -1,4 +0,0 @@ -apply plugin: 'dd-trace-java.dependency-locking' - -apply from: "$rootDir/gradle/java_deps.gradle" -apply from: "$rootDir/gradle/java_no_deps.gradle" diff --git a/gradle/spotless.gradle b/gradle/spotless.gradle index 7536733d14d..0a7ab260982 100644 --- a/gradle/spotless.gradle +++ b/gradle/spotless.gradle @@ -11,16 +11,16 @@ def scriptApplyExceptions = [ 'gradle/publish.gradle': [':dd-java-agent'] as Set, ] boolean forbidLegacyScriptApplies = project.rootProject.name == 'dd-trace-java' -def javaGradleApplyLinePattern = ~/^\s*(?:\w+\.)?apply(?:\s+from\s*:|\s*\(\s*from\s*=).*/ -// Script plugins that must be applied through a 'dd-trace-java.module.*' convention plugin instead. +def legacyScriptApplyLinePattern = ~/^\s*(?:\w+\.)?apply(?:\s+from\s*:|\s*\(\s*from\s*=).*/ +// Script plugins that must be replaced by their corresponding convention plugins. def forbiddenScriptApplies = [ - 'gradle/java.gradle' : 'Apply a \'dd-trace-java.module.*\' convention plugin instead of applying the script plugin \'gradle/java.gradle\' directly.', + 'gradle/java.gradle' : 'Apply the \'dd-trace-java.conventions.java\' convention plugin instead of applying the script plugin \'gradle/java.gradle\' directly.', 'gradle/publish.gradle': 'Apply the \'dd-trace-java.module.distributable.*\' convention plugin instead of applying the script plugin \'gradle/publish.gradle\' directly.', ] def forbidLegacyScriptApplyStep = { String text -> if (forbidLegacyScriptApplies) { text.readLines().each { line -> - if (javaGradleApplyLinePattern.matcher(line).matches()) { + if (legacyScriptApplyLinePattern.matcher(line).matches()) { forbiddenScriptApplies.each { script, message -> if (line.contains(script) && !scriptApplyExceptions.getOrDefault(script, []).contains(project.path)) { throw new AssertionError(message)