change DELETE to OBSOLETE (DELETE)

[GauravD2t]

References

• Fixes Resource Policy - The DELETE resource policy is not working DSpace#10741

Description

Change delete to OBSOLETE (DELETE) base on PR #10741
@tdonohue

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

• First, ...
• Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[GauravD2t]

Hello @tdonohue
I hope you are doing well.
I have already submitted my code for this issue (see PR: #4484
), but it has not been reviewed yet. I just wanted to follow up and kindly request a review whenever you get some time.

Please let me know if any changes or additional information are required from my side.

Thank you for your time and consideration.

[tdonohue]

@GauravD2t : This PR (along with the others you've alerted me to today) is currently in our "needs reviewers" column which means it's waiting on volunteer reviewers to help us to review/test it. Once a volunteer can give it a review/test and approves it, then we will work to get it merged. (I currently won't be able to get to this myself as I am reviewing higher priority PRs.) If you find this PR is waiting for a while, you are also welcome to partner with another developer and "trade" code reviews.

[marsaoua]

@GauravD2t This certainly fixes the issue. However, I think the wording OBSOLETE (DELETE) in the UI could be unclear for some users. Could it be possible to display DELETE in the UI and send back OBSOLETE (DELETE) to the API?

[marsaoua]

@GauravD2t you must change it also in the view table

[marsaoua]

@GauravD2t A single comprehensible commit would be great.

[marsaoua]

@GauravD2t It looks good to me! Could you please consolidate the commits into a single comprehensive commit. Thanks

[marsaoua]

@GauravD2t IMHO there is no need to have multiple commits for these changes. A single commit will serve to enhance readability and traceability. Can you please squash all commits into a single comprehensive commit?! Thanks.

[GauravD2t]

Thanks for the feedback, @marsaoua! I've just consolidated everything into one clean commit. Ready for another look when you have a moment

[marsaoua]

Thanks @GauravD2t!
The issue is fixed and the changes look good to me.

@tdonohue Don't know why the tests failed though

[tdonohue]

👍 Thanks @GauravD2t ! I've verified this allows the DELETE policies to be used/saved again.

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-4484-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-4484-to-dspace-7_x
git switch --create backport-4484-to-dspace-7_x
git cherry-pick -x 7b5aec4595e779b97271dd72014103c97025a21d

[dspace-bot]

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4484-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4484-to-dspace-8_x
git switch --create backport-4484-to-dspace-8_x
git cherry-pick -x 7b5aec4595e779b97271dd72014103c97025a21d

[dspace-bot]

Backport failed for dspace-9_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-9_x
git worktree add -d .worktree/backport-4484-to-dspace-9_x origin/dspace-9_x
cd .worktree/backport-4484-to-dspace-9_x
git switch --create backport-4484-to-dspace-9_x
git cherry-pick -x 7b5aec4595e779b97271dd72014103c97025a21d

[tdonohue]

@GauravD2t : This PR was unable to be auto-backported to any older releases of DSpace (9.x, 8.x or 7.x). Ideally, we'd like to backport this to 9.x at a minimum. If you have a chance, could you create a manual backport PR against the dspace-9_x branch? (You are also welcome to create backport PRs for 8.x and 7.x if you'd like to see this fix make it in those releases as well)

[GauravD2t]

@GauravD2t : This PR was unable to be auto-backported to any older releases of DSpace (9.x, 8.x or 7.x). Ideally, we'd like to backport this to 9.x at a minimum. If you have a chance, could you create a manual backport PR against the dspace-9_x branch? (You are also welcome to create backport PRs for 8.x and 7.x if you'd like to see this fix make it in those releases as well)

Hi @tdonohue,
have manually backported the fix to the dspace-9_x branch and opened a new pull request here: #5717.

I've resolved the merge conflicts and consolidated everything into a single, clean commit. The linting and import sorting errors have also been fixed, so the automated checks should pass successfully now.

[GauravD2t]

fix: change DELETE to OBSOLETE (DELETE) and update view table (#4484) #5717

#5717