Skip to content

docs: add soul skill carryover design#168

Merged
JOY (JOY) merged 1 commit into
devfrom
codex/soul-skill-sync
May 23, 2026
Merged

docs: add soul skill carryover design#168
JOY (JOY) merged 1 commit into
devfrom
codex/soul-skill-sync

Conversation

@JOY
Copy link
Copy Markdown
Contributor

Summary

  • Add the soul skill carryover and sync design contract.
  • Define how learned soul skills, body imprint, physical body capability, gear, soul-body sync, and server validation interact after reinhabitation.
  • Link the new design doc from the GDD, alpha GDD, vertical slice spec, systems index, decision register, stats/skills doc, roadmap, changelog, and GitBook summary.

Local review

  • Local code-review fallback: APPROVED. Docs-only change; no backend/auth/social stack change; no Unity client model calls; no LLM authority expansion; carryover, sync, and effective execution stay server-owned and validated by Nakama/Fusion.

Verification

  • npx.cmd markdownlint-cli2 "docs/design/12-game-design-document.md" "docs/design/14-character-stat-and-relationship-system.md" "docs/design/26-alpha-game-design-document.md" "docs/design/38-alpha-design-decision-register.md" "docs/design/39-alpha-stats-and-skills-design.md" "docs/design/40-soul-skill-carryover-and-sync.md" "docs/design/03-systems-index.md" "docs/design/02-vertical-slice-spec.md" "docs/SUMMARY.md" "ROADMAP.md" "CHANGELOG.md"
  • Markdown link resolver for changed docs: pass
  • rg -n "—|–|…" ...changed docs...: no matches
  • git diff --check
  • git diff --cached --check

@JOY JOY (JOY) merged commit 234896a into dev May 23, 2026
1 check passed
@JOY JOY (JOY) deleted the codex/soul-skill-sync branch May 23, 2026 05:17
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de1e656422

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

| `sync_requirement` | Minimum sync threshold |
| `physical_requirements` | Required stats, body tags, injury tolerance, or anatomy |
| `knowledge_requirements` | Required learned skill, memory, recipe, language, faction knowledge |
| `carryover_rule` | full, partial, locked_until_capable, body_only, equipment_only, policy_only, forbidden |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reconcile carryover_rule values across design contracts

The new data contract introduces carryover_rule values (full, partial, locked_until_capable, body_only, etc.) that conflict with the existing alpha contract in docs/design/39-alpha-stats-and-skills-design.md (none, partial, full, or explicit rule id). Because both docs are now referenced as implementation sources, this creates an ambiguous enum for backend and Unity DTO/schema work, which can lead to incompatible serialization and validation rules depending on which document a developer follows.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant