docs: add soul skill carryover design#168
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de1e656422
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| | `sync_requirement` | Minimum sync threshold | | ||
| | `physical_requirements` | Required stats, body tags, injury tolerance, or anatomy | | ||
| | `knowledge_requirements` | Required learned skill, memory, recipe, language, faction knowledge | | ||
| | `carryover_rule` | full, partial, locked_until_capable, body_only, equipment_only, policy_only, forbidden | |
There was a problem hiding this comment.
Reconcile carryover_rule values across design contracts
The new data contract introduces carryover_rule values (full, partial, locked_until_capable, body_only, etc.) that conflict with the existing alpha contract in docs/design/39-alpha-stats-and-skills-design.md (none, partial, full, or explicit rule id). Because both docs are now referenced as implementation sources, this creates an ambiguous enum for backend and Unity DTO/schema work, which can lead to incompatible serialization and validation rules depending on which document a developer follows.
Useful? React with 👍 / 👎.
Summary
Local review
code-reviewfallback: APPROVED. Docs-only change; no backend/auth/social stack change; no Unity client model calls; no LLM authority expansion; carryover, sync, and effective execution stay server-owned and validated by Nakama/Fusion.Verification
npx.cmd markdownlint-cli2 "docs/design/12-game-design-document.md" "docs/design/14-character-stat-and-relationship-system.md" "docs/design/26-alpha-game-design-document.md" "docs/design/38-alpha-design-decision-register.md" "docs/design/39-alpha-stats-and-skills-design.md" "docs/design/40-soul-skill-carryover-and-sync.md" "docs/design/03-systems-index.md" "docs/design/02-vertical-slice-spec.md" "docs/SUMMARY.md" "ROADMAP.md" "CHANGELOG.md"rg -n "—|–|…" ...changed docs...: no matchesgit diff --checkgit diff --cached --check