feat: polish quest tracker journal#163
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 725b1a56a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| var state = $"{_fpsText}|{player?.Level}|{player?.Hp}|{player?.BodyTimeRemainingSeconds}|{context?.body?.body_id}|{BuildQuestTrackerState(context?.body?.quests, chat)}|{_questJournalOpen}|{BuildAuthDebugState(gateway)}|{_promptTraceSummary}|{_gameplayLedgerSummary}"; | ||
| if (state == _lastHudState) |
There was a problem hiding this comment.
The new journal UI is rendered only when RenderRuntimeHud decides state changed, but the cache key at this point only tracks BuildQuestTrackerState(...), which collapses quest data down to the single active quest. If a non-active quest changes (for example in a multi-quest list), _lastHudState can stay identical and RenderQuestJournal(...) is skipped, leaving stale journal content until some unrelated field changes. Please include a journal-specific hash of the displayed quest entries (or always render the journal when open) so journal updates are not dropped.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
Notes