Skip to content

fix: stabilize prototype backend and Unity smoke#160

Merged
JOY (JOY) merged 1 commit into
devfrom
codex/backend-unity-stability-smoke
May 23, 2026
Merged

fix: stabilize prototype backend and Unity smoke#160
JOY (JOY) merged 1 commit into
devfrom
codex/backend-unity-stability-smoke

Conversation

@JOY
Copy link
Copy Markdown
Contributor

Summary

  • Stabilize Nakama decision handling with shorter DOS.AI timeouts, context-cancel recovery, safe storage retries, and autonomous model backoff.
  • Harden Unity Play Mode by serializing Nakama RPC transport, aborting active UnityWebRequests on shutdown, rebuilding incomplete HUD surfaces, and keeping quest tracker state refreshed.
  • Add Unity 6.5 beta smoke fixes for Fusion CodeGen diagnostic paths, duplicate Xcode assembly references, local health tooling, Play Mode checklist, and agent dev-sync rules.
  • Preserve merged alpha design work while moving AI NPC research docs to non-conflicting 33 and 34 design numbers.

Verification

  • npm.cmd run build in backend/nakama
  • npm.cmd test in backend/nakama
  • git diff --check and git diff --cached --check
  • PowerShell parser check for tools/windows/*.ps1 and tools/launch-local-second-client.ps1
  • FunPlay MCP request_recompile + wait_for_compilation: no compile errors
  • Unity Play Mode smoke for 90 seconds: no errors, only the known Visual Studio UDP messaging warning
  • Local code-review fallback: approved with one follow-up suggestion to split player-chat/NPC autonomous Nakama RPC priority lanes if latency grows

Notes

  • Commit was created with --no-gpg-sign because the local SSH signing agent refused the signing operation.
  • Fusion CodeGen is vendored under this repo. The Unity 6.5 beta compatibility patch may need reapplying if the Fusion asset is upgraded.

@JOY JOY (JOY) marked this pull request as ready for review May 23, 2026 01:25
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0522a1aeb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment on lines +715 to +719
action: "stop",
reason: "request_context_canceled",
confidence: 0.1,
source: "fallback",
source_reason: "nakama_context_canceled"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Return an allowed action for canceled decision RPC

rpcAgentDecide now returns a hardcoded fallback action: "stop" when context is canceled, but this bypasses the normal allowed-intent validation path. In player-chat turns, BuildDecisionRequest sends allowed = ["say"] (see PrototypeAgentBrain), so this response can be out-of-contract and causes the chat loop to treat the turn as handled and clear pending chat without a reply. Please derive the fallback action from request.allowed (or keep it as an error) so canceled requests cannot emit disallowed intents.

Useful? React with 👍 / 👎.

}
else {
$packageManagerMatches = @($logTail | Select-String -Pattern 'The "path" argument must be of type string|Failed to resolve packages|Package Manager' -SimpleMatch:$false)
$compileMatches = @($logTail | Select-String -Pattern "Assets\\.*\\.cs\\(.*\\): error CS|Compilation failed|Compiler errors")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fix compile-error regex to detect Unity compiler failures

The compile-error pattern uses Assets\\.*\\.cs..., which regex-parses as Assets\.*\.cs and matches only repeated dots after Assets\, not real paths like Assets\Scripts\Foo.cs(...). As a result, check-local-health.ps1 can miss actual error CS... lines in Editor.log and incorrectly report Unity Compile as OK, reducing the reliability of the local smoke gate.

Useful? React with 👍 / 👎.

@JOY JOY (JOY) force-pushed the codex/backend-unity-stability-smoke branch from 0522a1a to 03e5eac Compare May 23, 2026 01:38
@JOY
Copy link
Copy Markdown
Contributor Author

Codex (@codex) review

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@JOY JOY (JOY) merged commit 8c114dd into dev May 23, 2026
2 checks passed
@JOY JOY (JOY) deleted the codex/backend-unity-stability-smoke branch May 23, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant