Merge branch 'main' into coursework/sprint-3

Author: Ebrahim-Moqbel

Sprint-1/2-mandatory-errors/4.js

@@ -1,2 +1,2 @@
-const 12HourClockTime = "20:53";
-const 24hourClockTime = "08:53";
+const 12HourClockTime = "8:53pm";
+const 24hourClockTime = "20:53";

Sprint-2/4-mandatory-interpret/time-format.js

@@ -1,5 +1,9 @@
 function pad(num) {
-  return num.toString().padStart(2, "0");
+  let numString = num.toString();
+  while (numString.length < 2) {
+    numString = "0" + numString;
+  }
+  return numString;
 }
 
 function formatTimeDisplay(seconds) {
@@ -30,5 +34,5 @@ function formatTimeDisplay(seconds) {
 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
 // =============> write your answer here
 
-// e) What is the return value assigned to num when pad is called for the last time in this program?  Explain your answer
+// e) What is the return value of pad when it is called for the last time in this program?  Explain your answer
 // =============> write your answer here

Sprint-3/1-implement-and-rewrite-tests/README.md

@@ -8,7 +8,7 @@ to choose test values that thoroughly test a function.
 In the `implement` directory you've got a number of functions you'll need to implement.
 For each function, you also have a number of different cases you'll need to check for your function.
 
-Write your assertions and build up your program case by case. Don't rush to a solution. The point of these assignments is to learn how to write assertions and build up a program step by step.
+Write your implementation and your tests to cover the cases the function should fulfil.
 
 Here is a recommended order:
 

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -98,8 +98,10 @@ try {
   getCardValue("invalid");
 
   // This line will not be reached if an error is thrown as expected
-  console.error("Error was not thrown for invalid card");
-} catch (error) {}
+  console.error("Error was not thrown for invalid card 😢");
+} catch (e) {
+  console.log("Error thrown for invalid card 🎉");
+}
 
 // What other invalid card cases can you think of?
 

Sprint-3/2-practice-tdd/repeat-str.js

@@ -1,4 +1,6 @@
 function repeatStr() {
+  // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat).
+  // The goal is to re-implement that function, not to use it.
   return "hellohellohello";
 }