From 3d200d7388351c9eed8f60528618f4f0085e5ece Mon Sep 17 00:00:00 2001 From: Chrison Simtian Date: Fri, 2 Oct 2026 00:39:45 +1300 Subject: [PATCH] build: move Fallout to 10.4.0 from nuget.org (the edge pin was pulled) Fallout.* 2026.1.0-preview.5.gd84fad5cd7 no longer exists on the Fallout-build GitHub Packages feed (it now carries only 10.5.0-preview.*), so the next CI run would fail at restore; local builds only work from the package cache. It already broke ProxmoxSharp's CI (fixed in ProxmoxSharp#25). Pin the 10.4.0 stable line, restore everything from nuget.org, and drop the Fallout feed, its credentials and the PACKAGES_PAT env from both workflows. Test and Pack verified locally without the PAT. Co-Authored-By: Claude Opus 5.5 (1M context) Claude-Session: https://claude.ai/code/session_01V2afcTcowT1YVBwLzrJFtH --- .github/workflows/ci.yml | 6 ------ .github/workflows/publish.yml | 8 ++------ README.md | 5 ++--- build.ps1 | 4 ++-- build.sh | 4 ++-- build/_build.csproj | 9 +++++---- nuget.config | 23 ++++------------------- 7 files changed, 17 insertions(+), 42 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 69e33e2..ae8e147 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,11 +25,5 @@ jobs: # UnifiSharp.Api client from the committed OpenAPI spec via Kiota (Generated/ # is gitignored), then compiles everything; Test skips live integration tests # automatically without a secrets.env. - # - # GITHUB_PACKAGES_PAT authenticates the Fallout-build package feed (nuget.config) - # so the build/ project can restore Fallout.*. PACKAGES_PAT is a PAT with - # read:packages on the Fallout-build org. - name: Build & test (Fallout) - env: - GITHUB_PACKAGES_PAT: ${{ secrets.PACKAGES_PAT }} run: ./build.sh Test diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c1ffe48..34fb8a2 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -10,8 +10,7 @@ name: publish # # Requires a nuget.org Trusted Publishing policy for this repo + this workflow file # (publish.yml) with Environment=Nuget.org, and the NUGET_USER secret (nuget.org -# profile name). GITHUB_PACKAGES_PAT (from PACKAGES_PAT) only authenticates the -# Fallout-build feed for the build/ project. +# profile name). on: push: branches: [main] @@ -53,11 +52,8 @@ jobs: with: user: ${{ secrets.NUGET_USER }} - # Fallout Pack + Publish. GITHUB_PACKAGES_PAT authenticates the Fallout-build - # feed (build/ project restore); the push uses the short-lived nuget.org key. + # Fallout Pack + Publish; the push uses the short-lived nuget.org key. - name: Publish (Fallout → nuget.org) - env: - GITHUB_PACKAGES_PAT: ${{ secrets.PACKAGES_PAT }} run: | ARGS=(Publish --nuget-api-key "${{ steps.login.outputs.NUGET_API_KEY }}") if [[ -n "${{ steps.ver.outputs.suffix }}" ]]; then diff --git a/README.md b/README.md index 444d6a9..e0b89b9 100644 --- a/README.md +++ b/README.md @@ -55,9 +55,8 @@ build system, a NUKE successor). Targets: `Compile` → `Test` → `Pack` → `P ./build.sh Pack # produce the Chrison.* nupkgs into artifacts/ ``` -Requires the .NET 10 SDK (see `global.json`) and `GITHUB_PACKAGES_PAT` in the -environment (a PAT with `read:packages` on the Fallout-build org — the build restores -`Fallout.*` from that feed, see `nuget.config`). CI runs `./build.sh Test` on push/PR. +Requires the .NET 10 SDK (see `global.json`); everything, including `Fallout.*`, +restores from nuget.org with no credentials. CI runs `./build.sh Test` on push/PR. ## Use it diff --git a/build.ps1 b/build.ps1 index a20a6ab..e69f346 100755 --- a/build.ps1 +++ b/build.ps1 @@ -1,7 +1,7 @@ #!/usr/bin/env pwsh # UnifiSharp build entrypoint (Fallout build). Requires the .NET 10 SDK on PATH -# (see global.json) and, for restoring the Fallout.* build packages, GITHUB_PACKAGES_PAT -# in the environment (a PAT with read:packages on the Fallout-build org; see nuget.config). +# (see global.json). Everything, including the Fallout.* build packages, restores from +# nuget.org with no credentials (see nuget.config). # # ./build.ps1 # default target: Test # ./build.ps1 Pack --version-suffix preview.42 diff --git a/build.sh b/build.sh index d2e0344..3151749 100755 --- a/build.sh +++ b/build.sh @@ -1,7 +1,7 @@ #!/usr/bin/env bash # UnifiSharp build entrypoint (Fallout build). Requires the .NET 10 SDK on PATH -# (see global.json) and, for restoring the Fallout.* build packages, GITHUB_PACKAGES_PAT -# in the environment (a PAT with read:packages on the Fallout-build org; see nuget.config). +# (see global.json). Everything, including the Fallout.* build packages, restores from +# nuget.org with no credentials (see nuget.config). # # ./build.sh # default target: Test # ./build.sh Pack --version-suffix preview.42 diff --git a/build/_build.csproj b/build/_build.csproj index c39f69c..1f77cef 100644 --- a/build/_build.csproj +++ b/build/_build.csproj @@ -4,7 +4,8 @@ system, a NUKE successor). Restore/Compile/Test/Pack/Publish targets wrap the native `dotnet` toolchain; run via ./build.sh / ./build.ps1 or directly with `dotnet run` on this project (target as the arg). Fallout packages come - from the Fallout-build edge feed (see ../nuget.config); pinned for repro. --> + from nuget.org (10.4.0 stable; the 2026.1.0-preview edge pin was pulled from + the Fallout-build feed, same move as ProxmoxSharp#25); pinned for repro. --> Exe @@ -20,9 +21,9 @@ - - - + + + diff --git a/nuget.config b/nuget.config index 7082505..089d507 100644 --- a/nuget.config +++ b/nuget.config @@ -2,28 +2,13 @@ + - - - - - - - - - - - - -