BiocCheck will complain on patterns such as:
But I think this is fine if the second element is an integer literal. The danger of 1: only lies when the second element is a variable is:
I believe having this check lump both cases together is doing a disservice to users as it doesn't help them understand why and when : is bad.
It also makes BiocCheck unnecessary noisy and teaches users to ignore it, even for a number of important issues currently reported in existing packages.
BiocCheck will complain on patterns such as:
But I think this is fine if the second element is an integer literal. The danger of
1:only lies when the second element is a variable is:I believe having this check lump both cases together is doing a disservice to users as it doesn't help them understand why and when
:is bad.It also makes BiocCheck unnecessary noisy and teaches users to ignore it, even for a number of important issues currently reported in existing packages.