Skip to content

Partition export - treat corrupted_data as non retryable #2313

Description

@arthurpassos

It is actually low priority, no issue can arise from that aside from waste of resources

Medium: CORRUPTED_DATA at commit is treated as retryable
Impact: All-parts-done with empty paths_in_destination throws CORRUPTED_DATA, which is not in isNonRetryableExportError. Plain tryCommit leaves PENDING and retries every tick until task_timeout_seconds.
Anchor: MergeTreePartitionExportScheduler::tryCommit + ExportPartitionUtils::isNonRetryableExportError
Trigger: Descriptor with all parts done but empty exported paths, then commit.
Why defect: Local corruption cannot succeed by retrying; should fail closed.
Fix direction (short): Treat CORRUPTED_DATA (at least on commit) as non-retryable → FAILED.
Regression test direction (short): Force empty paths at commit; expect FAILED, not prolonged PENDING.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions