From a190eb6c7f778909bdae243d4ecf742c55fb7859 Mon Sep 17 00:00:00 2001 From: wxg0103 <727495428@qq.com> Date: Wed, 15 Jul 2026 14:02:27 +0800 Subject: [PATCH] fix: enhance model validation to check for workspace_id and handle non-existent models --- .../serializers/model_serializer.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/apps/models_provider/serializers/model_serializer.py b/apps/models_provider/serializers/model_serializer.py index 84977af73de..0c60472da10 100644 --- a/apps/models_provider/serializers/model_serializer.py +++ b/apps/models_provider/serializers/model_serializer.py @@ -485,18 +485,19 @@ def is_valid(self, *, raise_exception=False): super().is_valid(raise_exception=True) validated_data = self.validated_data - model = ( - QuerySet(Model) - .filter( - id=validated_data.get("id"), - workspace_id=validated_data.get("workspace_id"), - ) - .first() - ) + model = QuerySet(Model).filter( + id=validated_data["id"], + ).first() if model is None: raise AppApiException(500, _("Model does not exist")) + if model.workspace_id == "None": + return model + + if model.workspace_id != validated_data["workspace_id"]: + raise AppApiException(500, _("Model does not exist")) + return model def get_model_params(self, with_valid=True):